Improve log message when tiled image isn't displayed #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the TiledGeolocatedImage is panned to leave the canvas completely a ValueError exception is raised to notify about this and also a WARNING log message is generated (it can be discussed, whether this case is worth a warning, but...). This commit enhances the wording and adds the ValueError exception message to the log message in the hope to reduce confusion about its meaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
This is the first commit taken directly from the EUMETSAT gitlab that was contributed by their contractors. It makes sense and is a simple fix. This is a cherry-pick so it completely breaks commit history with their version, but that's going to have to happen if we only merge specific pieces (I'd like to merge all of it).