Skip to content

Replace / with \\ throughout Prefix where present in qt.conf, to fix … #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2021
Merged

Replace / with \\ throughout Prefix where present in qt.conf, to fix … #310

merged 1 commit into from
Jan 11, 2021

Conversation

rayg-ssec
Copy link
Member

Partially tested qt.conf update during packaging to address #308

  • Extract Prefix string
  • replace / with \ in Prefix
  • replace prefix string with new version throughout qt.conf configuration file

Also now uses text-mode open() when reading and writing qt.conf.

This is intended to allow conda-unpack to properly detect and amend Prefix on Windows.

djhoese
djhoese approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@djhoese djhoese self-assigned this Jan 11, 2021
@djhoese djhoese merged commit 5c9f04d into ssec:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhoese djhoese djhoese approved these changes

Assignees

@djhoese djhoese

Labels
bug Something isn't working build: binary installer build: os compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayg-ssec @djhoese @k30n1