Skip to content

Update bundle scripts to handle installation directory being moved #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented May 27, 2020

Attempt at fixing #295. At the time of writing this is just the .sh script, but should work.

I started researching .bat file solutions and came across this: https://stackoverflow.com/questions/130116/windows-batch-commands-to-read-first-line-from-text-file. I'm not sure how Windows handles newlines and carriage returns the way @katherinekolman has it writing to the file. Kat do you think you could look in to this and test it on Windows? The idea is that if you run SIFT once, then move the directory to a new directory and run it again, conda-unpack should run and data should load fine.

@djhoese djhoese added the bug Something isn't working label May 27, 2020
@djhoese djhoese self-assigned this May 27, 2020
@katherinekolman
Copy link
Contributor

I updated the .bat script and tested it on Windows, but I'm not sure why the tests are failing like this...

@djhoese
Copy link
Member Author

djhoese commented May 29, 2020

Looks like a new version of pyvirtualdisplay is breaking things for pytest xvfb: The-Compiler/pytest-xvfb#22

Let's give it 24 hours and then see where things stand. We can limit the version of pyvirtualdisplay to <1.0 if we have to.

@djhoese
Copy link
Member Author

djhoese commented Jun 9, 2020

A new version of pytest-xvfb just came out, I restarted the tests, and now things seem to be passing.

@djhoese djhoese merged commit 62aa1f2 into ssec:master Jun 9, 2020
@djhoese djhoese deleted the bugfix-bundle-dir-move branch June 9, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants