Skip to content

Conversation

@GwydionJon
Copy link
Contributor

This fixes #104, #103, #107 and #98

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #120 (9f8d3b7) into main (75e9f49) will increase coverage by 2.92%.
The diff coverage is 86.79%.

❗ Current head 9f8d3b7 differs from pull request most recent head 412ff9b. Consider uploading reports for the commit 412ff9b to get more accurate results

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   69.28%   72.21%   +2.92%     
==========================================
  Files          22       21       -1     
  Lines        1478     1605     +127     
==========================================
+ Hits         1024     1159     +135     
+ Misses        454      446       -8     
Impacted Files Coverage Δ
ammico/display.py 80.82% <40.00%> (-1.27%) ⬇️
ammico/test/test_summary.py 81.94% <58.06%> (+9.21%) ⬆️
ammico/summary.py 93.50% <95.12%> (+6.83%) ⬆️
ammico/test/test_display.py 94.59% <100.00%> (+0.30%) ⬆️
ammico/test/test_objects.py 100.00% <100.00%> (ø)
ammico/test/test_utils.py 100.00% <100.00%> (ø)
ammico/utils.py 93.90% <100.00%> (+3.70%) ⬆️

@GwydionJon GwydionJon requested a review from iulusoy June 21, 2023 13:05
GwydionJon and others added 5 commits June 27, 2023 14:09
* changed summmary.py logic

* fixing test_summary

* added macos for testing

* fixed_display_test

* fixed docs and exceptions

* added dropout menu for summary

* added new SummaryDetector to AnalysisExplorer

* bug fixing

* code improving

* fixed test_display

* fixed code smells

* reduce tests for macos

* added some tests and exceptions for summary init

* changed CI, runs pytest independently

* exclude test_analysisExplorer from macos in CI

* moved some tests from test_init_summary to test_advanced_init_summary and mark them as long

---------

Co-authored-by: Inga Ulusoy <[email protected]>
* fixed coverage report
@iulusoy iulusoy force-pushed the provide_err_msg_empty_file_location branch from 9f8d3b7 to 412ff9b Compare June 27, 2023 12:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iulusoy iulusoy merged commit 2a87bc5 into main Jun 28, 2023
@iulusoy iulusoy deleted the provide_err_msg_empty_file_location branch June 28, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants