Remove UnsafeCursor from the JNI API #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Jul 14, 2025
| auto inputByteArrayElements = env->GetByteArrayElements(inputByteArray, NULL); | ||
| auto inputEnd = static_cast<size_t>(env->GetIntField(input, jniZstd->unsafeCursorEnd)); |
There was a problem hiding this comment.
Seems in hindsight like an obvious improvement. Much simpler to have one side knowing the internals of the other, than both sides reaching around.
yschimke
reviewed
Jul 14, 2025
| assertThat(remaining).isEqualTo(0) | ||
|
|
||
| return output.data!!.toByteString(outputOffset, compressor.outputBytesProcessed) | ||
| return outputArray.toByteString(outputOffset, compressor.outputBytesProcessed) |
There was a problem hiding this comment.
outputOffset is used surprisingly, it seems it could always be 0 if outputArray is always freshly created. Is this for testing?
There was a problem hiding this comment.
Yeah, in practice it’ll be non-zero and I want to confirm the native code handles that okay.
yschimke
approved these changes
Jul 14, 2025
We should be able to split the Zstd+KMP stuff from the Zstd+Okio stuff.
swankjesse
force-pushed
the
jwilson.0713.okio_kmm
branch
from
f38036d to
019d78d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to split the Zstd+KMP stuff from the Zstd+Okio stuff.