Rename headlessIntegrationTest -> renderForTest and deprecate launchForTestingFrom* #1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
requested review from
zach-klippenstein and
a team
as code owners
saket
approved these changes
Aug 28, 2025
steve-the-edwards
force-pushed
the
sedwards/test-renaming
branch
from
cb3b818 to
c8475a2
Compare
japplin
approved these changes
Aug 28, 2025
steve-the-edwards
force-pushed
the
sedwards/test-renaming
branch
from
c8475a2 to
3c728f4
Compare
sins921
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the confusing overload of the two types of test harnesses that use the runtime directly.
renderForTestis a more accurate name since it is not strictly an 'integration' test (depending on how you define that). And the fact that it isheadlessis not really pertinent at this level of the API, that was an artifact of originally writing this API to run Android type tests that used Android dependencies but without having to render the UI (since the renderings just come out in the turbine).We do not have all the facilities of the
launchForTestingFrom*methods (such as starting with a snapshot) - but those are not extensively used AFAIK. They are also trivial to add torenderForTestand forward along torenderWorkflowIn. So this is somewhat of a premature deprecation (a soft deprecation), but at least it shows the direction.Closes #1411.
#1152 will remain because it has more specification of the further work required.