Make Logging Utils Public #1408
Merged
+30
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
requested review from
zach-klippenstein and
a team
as code owners
mannydelgado
approved these changes
Aug 13, 2025
| @@ -9,7 +9,7 @@ import com.squareup.workflow1.WorkflowInterceptor.WorkflowSession | |||
| import kotlin.reflect.KClass | |||
| import kotlin.reflect.KType | |||
|
|
|||
| internal fun WorkflowSession.toWfLoggingName(): String { | |||
| public fun WorkflowSession.toWfLoggingName(): String { | |||
There was a problem hiding this comment.
Since these are public should we include some sort of kdoc or example of an expected output.
There was a problem hiding this comment.
Good point. Will do.
| @@ -18,7 +18,7 @@ internal fun WorkflowSession.toWfLoggingName(): String { | |||
| } | |||
| } | |||
|
|
|||
| internal fun WorkflowIdentifier.toWfLoggingName(): String { | |||
| public fun WorkflowIdentifier.toWfLoggingName(): String { | |||
steve-the-edwards
force-pushed
the
sedwards/update-logging-visibility
branch
from
500730b to
f702c2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upstreamed these utils from internal repo, but they are still used there and we don't want to duplicate.