Draft: Demo permissive serialization model for Go SDK #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernjaleel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates the different serialization options outlined in this document:
https://www.notion.so/buildwithfern/Golang-Permissive-Deserialization-232b23082e4c80d0b47bd288fb28fd5d
With some simple test cases for demonstrating failure modes and expected outputs of each option. At the time of writing invalid deserialization is only demonstrated by the
GetPayoutResponse.Payout.IDfieldAdditionally, it looks like the existing
internal.ExtractExtraPropertiesperforms an unnecessary secondary unmarshal in theUnmarshalJSONcall path (1, 2). The PR also includes an additionalinternal.ExtractExtraPropertiesUnmarshalledfunction to reuse the first unmarshalled object for comparing keys agains the extra properties map