Parse Kotlin metadata manually to honor nullability and avoid kotlin-metadata-jvm dep

[AidanLaing]

Version: 2.6.0-SNAPSHOT
Exception: KotlinNullPointerException
Message: Response from {path to my suspend fun...} was null but response body type was declared as non-null

The current structure of my suspend fun in my service interface:

@POST("api/...")
suspend fun request(@Body body: Body): Response?

I'm using Gson for serialization.

Is there a way to declare the response body type as nullable that I'm missing? I've tried adding null safety on my response object with ? and @Nullable with no success.

[JakeWharton]

Not currently. I'm working on a parser for Kotlin metadata so we don't have to depend on a gigantic jar to read one isNullable boolean.

…

On Thu, Apr 11, 2019, 8:27 PM Aidan Laing ***@***.***> wrote: Version: 2.6.0-SNAPSHOT Exception: KotlinNullPointerException Message: Response from {path to my suspend fun...} was null but response body type was declared as non-null The current structure of my suspend fun in my service interface: @post("api/...") suspend fun ***@***.*** body: Body): Response? I'm using Gson for serialization. Is there a way to declare the response body type as nullable that I'm missing? I've tried adding null safety on my response object with ? and @nullable with no success. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3075>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEb6RFk0-5aDUMDF6fMlN9U2r9w7Hks5vf9MHgaJpZM4crGCw> .

[rodion-m]

@JakeWharton Please notice that suspend ...: List<*> also is not supported.
Version: 2.6.0-SNAPSHOT
For instance: suspend fun fetchStrings(): List<String>

[JakeWharton]

I'm not sure how that's related to null body handling. Feel free to file a separate issue with a failing test case.

…

On Wed, Apr 17, 2019, 9:41 PM Rodion Mostovoy ***@***.***> wrote: @JakeWharton <https://github.com/JakeWharton> Please notice that suspend ...: List<*> also is not supported. Version: 2.6.0-SNAPSHOT For instance: suspend fun fetchStrings(): List<string> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3075 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAQIEKC4PRPCZTA5WTQBNDPQ7GTBANCNFSM4HFMMCYA> .

[wlara]

Added @JakeWharton I'm getting a similar KotlinNullPointerException using a service that returns 204 (no content) on a delete call. Something like this:
@DELETE("/api/{id}") suspend fun deleteItem(@Path("id") id: String)
Would that use case also be fixed as part of this issue?

[JakeWharton]

No. That's #2867

[Hospes]

Hi there! Any chance to get update on this issue? :) Want to move to 2.6.0 and remove all other dependencies but can't cause of null response body not supported :(

[jgavazzisp]

Moved to #2867

[JakeWharton]

That is not related to this issue. It's #2867.

[JavierSegoviaCordoba]

So at this moment we should force an exception with a interceptor for 204 responses?

[JakeWharton]

This issue has nothing to do with 204 handling and when it's fixed 204 handling won't have changed in any way. That's #2867.

[claucookie]

Just in case it helps. I was experiencing the exact same KotlinNPE issue over the last 2 days and after trying Converters and Adapters what really worked was to return Response<Unit> in the retrofit method declaration.

I use Retrofit 2.6.0.

[Pitel]

Any progress? We've just changed some of our REST endpoints to 204. So I thought it would be enought to just remove response type (making it Unit), but no.

Using Response<Unit> works 👍

[vladimirfx]

Why not:

https://github.com/Kotlin/kotlinx.reflect.lite