Skip to content

Remove newlines in detailed log messages #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Conversation

mtnpke
Copy link
Contributor

@mtnpke mtnpke commented May 14, 2025

The (officially deprecated, but still working) JLINKARM_EnableLogCom adds newlines add the end of every message that clobber the log output. Use rstrip() to remove the newlines.

The (officially deprecated, but still working) JLINKARM_EnableLogCom adds newlines add the end of every message that clobber the log output. Use rstrip() to remove the newlines.
Copy link
Contributor

@hkpeprah hkpeprah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Thanks for the contribution!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mtnpke
Copy link
Contributor Author

mtnpke commented Jun 16, 2025

As per e-mail from your company on 2025-05-29, a CLA is not required in the case of this PR.

@hkpeprah
Copy link
Contributor

Sorry, I'm not aware of an e-mail. Could you share the details?

@mtnpke
Copy link
Contributor Author

mtnpke commented Jun 17, 2025

forwarded

@hkpeprah
Copy link
Contributor

Confirmed. Thank you!

@hkpeprah hkpeprah merged commit 278e547 into square:master Jun 18, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants