Skip to content

Refine decorators for raw JTAG functions #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2025

Fixes #229

…d not a connection to the target being debugged. Additionally ensured that the TIF is set to JTAG for those raw JTAG functions
@CLAassistant
Copy link

CLAassistant commented Mar 26, 2025

CLA assistant check
All committers have signed the CLA.

@ghost ghost closed this Mar 26, 2025
@ghost ghost reopened this Mar 26, 2025
@hkpeprah hkpeprah requested review from Copilot and hkpeprah March 27, 2025 20:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refines the decorators for raw JTAG functions, ensuring that the functions enforce both the specific JTAG interface and an open connection.

  • Replaces the generic @connection_required decorator with a combination of @interface_required(enums.JLinkInterfaces.JTAG) and @open_required for JTAG-specific functions.
  • Updates the decorator usage for the jtag_create_clock, jtag_send, and jtag_flush functions in pylink/jlink.py.

Copy link
Contributor

@hkpeprah hkpeprah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ghost
Copy link
Author

ghost commented Mar 28, 2025

@hkpeprah thanks for approving.
I now see that all merge checks have passed. What's the procedure and timeline for merging and releasing? (no rush just wondering).
Thanks

@hkpeprah
Copy link
Contributor

I'll cut a patch release later today. Thank you!

@hkpeprah hkpeprah merged commit d863bdd into square:master Mar 28, 2025
5 checks passed
@hkpeprah
Copy link
Contributor

Should now be available in 1.5.1. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect decorators on raw JTAG functions in the JLink class
2 participants