Remove JVM specific API usage in common code #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding non-JVM targets will result in compilation failure
pyricau
reviewed
Jul 23, 2025
| "It is recommended to report your use-case of internal API to logcat issue tracker, " + | ||
| "so stable API could be provided instead" | ||
| ) | ||
| annotation class InternalLogcatApi |
There was a problem hiding this comment.
why add this? Why was the internal keyword not enough?
pyricau
reviewed
Jul 23, 2025
| @@ -63,9 +66,9 @@ inline fun Any.logcat( | |||
| } | |||
| val loggers = LogcatLogger.loggers.filter { it.isLoggable(priority) } | |||
| if (loggers.isNotEmpty()) { | |||
| val tagOrCaller = tag ?: outerClassSimpleNameInternalOnlyDoNotUseKThxBye() | |||
There was a problem hiding this comment.
The name outerClassSimpleNameInternalOnlyDoNotUseKThxBye() was picked so that Java code, which can see these methods, would not attempt to use it. Why rename?
There was a problem hiding this comment.
I was under the assumption that the InternalLogcatApi annotation will work on Java side. Turns out it doesn't
There was a problem hiding this comment.
Hmm it does work on Android Studio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding non-JVM targets will result in compilation failure