1.0.5 cocaine security fixes #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/git-fastclone.rb
Outdated
There was a problem hiding this comment.
I think it would be easier to read with separate named args, i.e.
Cocaine::CommandLine.new('git clone', '--quiet --reference :mirror :repository :directory')
.run(mirror: mirror, repository: url, directory: File.join(abs_clone_path, src_dir))
|
LGTM though it would be nice to polish this later. |
Contributor
Author
|
Gonna clean it up |
|
The code isn't the prettiest, but it does look safe after reading through it. This is safe from the two POCs I provided. I'm really not an expert on Cocaine::CommandLine though. I'd echo @dlubarov and suggest you use use multiple meaningfully named parameters in It looks like you're using the interpolations from Cocaine correctly and safely now. |
Contributor
Author
|
Yeah, it's really difficult to follow right now. I'll revert it and add the meaningfully-named parameters tomorrow. |
longboardcat
force-pushed
the
jchang/fix-security
branch
from
7778d2d to
9c6a28e
Compare
longboardcat
added a commit
that referenced
this pull request
Dec 17, 2015
1.0.5 cocaine security fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastclone is using cocaine improperly, allowing malicious command injection.