fix: Ensure we're referencing up-to-date swipe state when configuring interaction enabled #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
reviewed
Jul 30, 2025
| @@ -286,8 +286,11 @@ extension ItemCell { | |||
| private func set(state: SwipeActionState, animated: Bool = false) { | |||
| swipeState = state | |||
|
|
|||
| // Warning! : `swipeState` may be mutated to a new value via it's property | |||
There was a problem hiding this comment.
What's an example of this happening?
There was a problem hiding this comment.
In the original case it was: willPerformFirstActionAutomatically(ListableUI.SwipeActionsView.Side.right) becoming closed.
We get into this kind of re-entrant set(state:) situation if the swipe action completion is invoked synchronously.
I'm not sure if there's a better/safer way to restructure this stuff.
There was a problem hiding this comment.
Ahh interesting – synchronous completion handlers strike again... Got it!
There's probably some improvement, but this also seems like a conceptually fine/correct fix too!
kyleve
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://block.atlassian.net/browse/UI-9091
This resolves an issue where a cell would not respond to taps after the "full swipe" swipe action trigger.
The issue was that we were referencing stale swipe state when configuring
isUserInteractionEnabled. It was quite unintuitive when debugging this, but the lineswipeState = stateimmediately resulted in those variables holding different values while processing the swipe action 🙃. We would incorrectly fall into the.willPerformFirstActionAutomaticallycase, making the content view unresponsive, despite theswipeStatereporting as.closed.The SwipeActionsViewController has also been updated to demonstrate this is now working as expected.
Checklist
Please do the following before merging:
Mainsection.