Fix for issue #592, json query fix when question mark is used in data #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this PR? It would be great if we could have it merged :) |
|
I highly upvote this |
… is hardcoded to a ? Added compiler to the constructor of SqlResult Made ParameterPlaceholder public
kamisoft-fr
force-pushed
the
issue/592
branch
from
7597698 to
8c39678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix places where the parameterPlaceholder is hardcoded to a question mark ?
Since the SqlResult still contained ToString method which had the hardcoded placeholder, here is what I've done:
There is so a breaking change on the SqlResult class since its public, So the sqlkata version would be changed as major (2 to 3 or 3 to 4)