PR: Remove depreciated locale.getdefaultlocale
#24875
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows use win32 GetUserDefaultLocaleName instead of locale.getlocale due to non-BCP47 locale code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows use win32 GetUserDefaultLocaleName instead of locale.getlocale due to non-BCP47 locale code.
Description of Changes
locale.getdefaultlocaleis depreciated and is slated for removal in python 3.15.locale.getlocaleas the suggested alternative does not return BCP47 locale codes ("English_United States"rather than"en-US"). Instead call the win32GetUserDefaultLocaleNamefunction via thectypesbuiltin library in order to not add any dependencies.Issue(s) Resolved
Fixes #23318
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: athompson673