PR: Add optional support to create environments when creating a connection (Remote client) #24691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
changed the title
ccordoba12
force-pushed
the
add-remote-env-management
branch
2 times, most recently
from
1270613 to
347e5af
Compare
ccordoba12
force-pushed
the
add-remote-env-management
branch
2 times, most recently
from
5390e65 to
e4e4308
Compare
ccordoba12
force-pushed
the
add-remote-env-management
branch
from
e4e4308 to
5251790
Compare
- This button will only be visible if spyder-env-manager is available. - Also, don't translate SSH and JupyterHub tab text in NewConnectionPage because it's not necessary.
Also, add a back button to return from that page to the SSH authentication one.
The create_browsedir/create_browsefile methods had a hard-coded margin to align their button to the lineedit next to them in vertical layout.
- Also, remove bottom padding. - That way, there's going to be more space for content.
ccordoba12
force-pushed
the
add-remote-env-management
branch
6 times, most recently
from
1883120 to
9ed8bfb
Compare
Also, make size of that dialog fixed so padding can be set correctly.
These are third-party plugins whose functionality can be integrated with other core plugins if available.
…ectionDialog - This makes the UX clearer for users. - Move Connect button to be next to Cancel in connection pages to have the same UI as for New connections. - Show SSH info widget for any env creation method after connecting to the server for the first time (before we were showing it only after importing an env).
…ionDialog - Rename buttons with two words to a single one. This will help to display a simpler interface in other languages. - Stop is hidden when a connection is inactive and Connect when it's established. - Fix showing/hiding Back and enabling/disabling Save.
Also, fix skipping info validation if first SSH page is already validated.
ccordoba12
force-pushed
the
add-remote-env-management
branch
from
9ed8bfb to
aa70041
Compare
ccordoba12
changed the title
|
This is finally ready. Merging because the failure is unrelated to these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Visual changes
Options to create an environment
New widget (provided by Spyder-env-manager) to add packages to an environment
Issue(s) Resolved
Part of #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: