DATAGRAPH-255 Transaction Manager Compatibility with 1.7 AND 1.8 - and 1.6 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Author
|
Superseeded. I figured out how to create a pull request from a branch :) |
shahar-biron
added a commit
to FalkorDB/spring-data-falkordb
that referenced
this pull request
Oct 26, 2025
…patibility Spring Data Commons 4.0 requires the ValueExpressionDelegate parameter in the getQueryLookupStrategy method signature. This was identified by CodeRabbitAI comment spring-projects#52. Changes: - Add ValueExpressionDelegate import - Update getQueryLookupStrategy signature to include ValueExpressionDelegate parameter - Add @OverRide annotation (now correctly overriding parent method) Addresses CodeRabbitAI critical issue about method signature mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a factory that uses reflection to detect neo versions and create transaction managers