Skip to content

Polishing #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
quaff wants to merge 1 commit into from
Closed

Polishing #3016

quaff wants to merge 1 commit into from

Conversation

@quaff
Copy link
Contributor

@quaff quaff commented Jan 4, 2024

  1. reuse fields from super class
  2. remove unused constant
  3. add static modifier to inner class

@quaff
Polishing
0434bab 
1. reuse fields from super class
2. remove unused constant
3. add static modifier to inner class
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2024
mp911de
mp911de reviewed Jan 9, 2024
View reviewed changes
...java/org/springframework/data/repository/config/AnnotationRepositoryConfigurationSource.java
private final AnnotationMetadata enableAnnotationMetadata;
private final AnnotationAttributes attributes;
private final ResourceLoader resourceLoader;
private final Environment environment;
Copy link
Member

@mp911de mp911de Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are fine.

mp911de
mp911de reviewed Jan 9, 2024
View reviewed changes
...in/java/org/springframework/data/repository/config/RepositoryConfigurationSourceSupport.java
*/
public abstract class RepositoryConfigurationSourceSupport implements RepositoryConfigurationSource {

protected static final String DEFAULT_REPOSITORY_IMPL_POSTFIX = "Impl";
Copy link
Member

@mp911de mp911de Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't because we do not want to alter visibility.

@mp911de mp911de added the status: waiting-for-feedback We need additional information before we can continue label Jan 9, 2024
mp911de added a commit that referenced this pull request Jan 9, 2024
@mp911de
Polishing.
6623bd8 
Add missing override annotations. Refactor TypeFilterFunction into function to avoid additional property references.
Move off deprecated code.

Closes #3016
@mp911de mp911de closed this in 20d150f Jan 9, 2024
@mp911de mp911de added this to the 3.2.2 (2023.1.2) milestone Jan 9, 2024
@mp911de mp911de added type: task A general task and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mp911de mp911de mp911de left review comments

Assignees

No one assigned

Labels

type: task A general task

Projects

None yet

Milestone

3.2.2 (2023.1.2)

Development

Successfully merging this pull request may close these issues.

3 participants

@quaff @mp911de @spring-projects-issues