Use family instead of name to check os system #8907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
priority: normal
type: task
snicoll
added a commit
that referenced
this pull request
Apr 17, 2017
* pr/8907: Fix windows build of the Gradle plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to build source code in Windows 8.1 machine, it will throw a exception like "./gradlew is a not valid Win32 program". The root cause is in
spring-boot-gradle-pluginproject.nameis the name of the operating system, such likeWindows XPorWindows 8.1.I think we should use
familyto determine OS system.More detail can find in here: http://maven.apache.org/enforcer/enforcer-rules/requireOS.html