Use ObjectUtils.hashCode() for primitives #8766
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
Author
|
Having trouble to find out what checkstyle is apparently not happy with. |
Member
|
@dreis2211 I think I've just fixed the Checkstyle plugin's configuration so that the violations can be seen even when the build's run with |
Contributor
Author
|
Thanks @wilkinsona . As I screwed up the history a bit, I opened another clean one. Sorry for that. |
snicoll
added
status: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
while working on https://jira.spring.io/browse/SPR-15395 I noticed that Spring-Boot is creating some hash codes for primitives on its own as well. So this PR replaces those with calling Spring's ObjectUtils.hashCode() variants. Seemed more consistent than using the JDK ones, but I'd be happy to use them if you tell me to.
I hope you don't mind that I changed to ObjectUtils.nullSafeEquals/hashCode() in FileSnapshot for the one none-primitive field while being on this one.
Cheers,
Christoph