Skip to content

Conversation

@benelog
Copy link
Contributor

@benelog benelog commented Mar 13, 2023

The JobLauncherApplicationRunner does not launch multiple jobs by the commit - 55d6a87 .
The Javadoc in JobLauncherApplicationRunner was not updated. This PR fixed it.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 13, 2023
@philwebb philwebb added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 13, 2023
@philwebb philwebb added this to the 3.0.x milestone Mar 13, 2023
@benelog
Copy link
Contributor Author

benelog commented Mar 13, 2023

The test in JettyServletWebServerFactoryTests failed.

https://ci.spring.io/teams/spring-boot/pipelines/spring-boot-3.1.x/jobs/build-pull-requests/builds/70#L63de80fd:5177

:spring-boot-project:spring-boot:test
    org.springframework.boot.web.embedded.jetty.JettyServletWebServerFactoryTests > whenServerIsShuttingDownGracefullyThenResponseToRequestOnIdleConnectionWillHaveAConnectionCloseHeader()

I guess my change didn't affect the failure.

@wilkinsona
Copy link
Member

@benelog Yeah, unfortunately that test is rather flaky. Don't worry about it.

@wilkinsona
Copy link
Member

@benelog Thank you very much, and congratulations on making your first contribution to Spring Boot.

@benelog benelog deleted the fix-javadoc branch March 14, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants