Remove carriage returns in TypeUtils.getJavaDoc() #13779
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
|
On a second thought both line feed ('\n') and carriage return ('\r') should be removed, not system-dependent line separator. I'll update shortly. |
izeye
force-pushed
the
type-utils-line-separator
branch
from
dd56e22 to
f1997cf
Compare
izeye
changed the title
|
I've updated to remove carriage returns in addition to line feeds. |
snicoll
left a comment
snicoll
left a comment
There was a problem hiding this comment.
Thanks again for the PR! I've added a couple of comments
| if (javadoc != null) { | ||
| javadoc = javadoc.replaceAll("\\n", ""); | ||
| javadoc = javadoc.trim(); | ||
| javadoc = javadoc.replaceAll("[\r\n]+", "").trim(); |
There was a problem hiding this comment.
Can we do two passes instead (\r\n then \n)? Technically speaking that would replace \r
There was a problem hiding this comment.
@snicoll I thought removing "\r" in Javadoc, especially as description for application properties is safe. Am I missing something?
| ? this.env.getElementUtils().getDocComment(element) : null); | ||
| if (javadoc != null) { | ||
| javadoc = javadoc.replaceAll("\\n", ""); | ||
| javadoc = javadoc.trim(); |
There was a problem hiding this comment.
I still would like surrounding spaces to be removed. Do you disagree with that?
There was a problem hiding this comment.
@snicoll No, I just collapsed the two statements into one. I thought it's less verbose than before.
snicoll
added
type: enhancement
* pr/13779: Remove carriage returns in TypeUtils.getJavaDoc()
|
Thanks a lot for the feedback @izeye |
3 participants
This PR changes to use system-dependent line separator in
TypeUtils.getJavaDoc().