Use more Tag constants #13286
Closed
Use more Tag constants #13286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also created a PR for the same change but targeted to Micrometer Spring Boot 1.5.x support: micrometer-metrics/micrometer#629 |
snicoll
added a commit
that referenced
this pull request
May 29, 2018
* pr/13286: Use more Tag constants
Member
|
Thanks again for the PR @izeye! I hesitated to transform some of those expressions to ternary operators but I left your change as is in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to use more
Tagconstants where possible.This PR also aligns "exception" tag value in
WebFluxTagswith one inWebMvcTags, hence from "none" to "None".