Add BindingService.get*Binding(s)(String) API
#2629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some use-cases when we need to know upfront if specific binding is really bound. The goal is to prevent some security vulnerabilities when too many unexpected dynamic bindings, e.g. via router based on the `StreamBridge`. The `BindingService` provides for us `getProducerBindingNames()` and `getConsumerBindingNames()` which are not optimal for the task to check for binding presence * Introduce `BindingService.getProducerBinding(String bindingName)` and `getConsumerBindings(String bindingName)` to cover a use-case when we need to check for predefined bindings. This API might be useful in other use-case when we need to get access to managed bindings Related to: spring-cloud/stream-applications#330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some use-cases when we need to know upfront if specific binding is really bound.
The goal is to prevent some security vulnerabilities when too many unexpected dynamic bindings, e.g.
via router based on the
StreamBridge.The
BindingServiceprovides for usgetProducerBindingNames()and
getConsumerBindingNames()which are not optimalfor the task to check for binding presence
BindingService.getProducerBinding(String bindingName)andgetConsumerBindings(String bindingName)to cover a use-case when we need to check for predefined bindings.This API might be useful in other use-case when we need to get access to managed bindings
Related to: spring-cloud/stream-applications#330