Support configuring queuedMaxSpans in AsyncReporter #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@asibross @narayaruna |
Contributor
|
Thanks @karkum ! |
Contributor
Author
|
@marcingrzejszczak thanks for the review. Do you know when this change will be released? |
Contributor
|
https://github.com/spring-cloud/spring-cloud-release/milestone/121 today according to the calendar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the ability to configure the
queuedMaxSpansproperty of the AsyncReporter with a config:spring.zipkin.queuedMaxSpans, the default is unchanged.We would like to be able to tweak this property to support applications with a high-volume of spans, which are dropped once the queue is full.
I understand that this bean could be overridden to achieve the same result, but this seems like a more ideal way to configure this property.
There is also
queuedMaxByteswhich provides a memory-based bound on the queue (defaults to 1%), I can also override that property in this PR (although that is not necessary for my current use-case)