Remove additional Commons HttpClient dependencies. #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjbaxter
commented
Nov 15, 2022
| @@ -1,77 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
This is the main thing I was unsure about. I did not understand why we had this configuration class. It pretty much duplicated what was in FeignAutoConfiguration and was only used in OkHttpFeignLoadBalancerConfiguration. Seems to me we can just remove this and use whats in FeignAutoConfiguration
ryanjbaxter
force-pushed
the
cleanup-httpclient-configuration
branch
from
ecb850a to
5a1fccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Fix For #788