make auto-configurations public + fix changes that came from boot 5 #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
wind57
commented
Oct 21, 2025
| Fabric8DiscoveryClientAutoConfiguration.class, KubernetesDiscoveryPropertiesAutoConfiguration.class, | ||
| Fabric8DiscoveryClientSpelAutoConfiguration.class, Fabric8ReactiveDiscoveryClientAutoConfiguration.class }) | ||
| final class Fabric8ReactiveDiscoveryHealthAutoConfiguration { | ||
| public final class Fabric8ReactiveDiscoveryHealthAutoConfiguration { |
wind57
commented
Oct 21, 2025
| Fabric8DiscoveryClientAutoConfiguration.class, KubernetesDiscoveryPropertiesAutoConfiguration.class, | ||
| Fabric8DiscoveryClientSpelAutoConfiguration.class }) | ||
| final class Fabric8ReactiveDiscoveryClientAutoConfiguration { | ||
| public final class Fabric8ReactiveDiscoveryClientAutoConfiguration { |
There was a problem hiding this comment.
make class public and remove stale comment from it
Signed-off-by: wind57 <[email protected]>
wind57
commented
Oct 21, 2025
| @ConditionalOnCloudPlatform(CloudPlatform.KUBERNETES) | ||
| @AutoConfigureAfter(KubernetesDiscoveryPropertiesAutoConfiguration.class) | ||
| final class Fabric8DiscoveryClientSpelAutoConfiguration { | ||
| public final class Fabric8DiscoveryClientSpelAutoConfiguration { |
wind57
commented
Oct 21, 2025
| @AutoConfigureAfter({ Fabric8AutoConfiguration.class, KubernetesDiscoveryPropertiesAutoConfiguration.class, | ||
| Fabric8DiscoveryClientSpelAutoConfiguration.class, Fabric8DiscoveryClientSpelAutoConfiguration.class }) | ||
| final class Fabric8DiscoveryClientAutoConfiguration { | ||
| public final class Fabric8DiscoveryClientAutoConfiguration { |
wind57
commented
Oct 21, 2025
| @ConditionalOnKubernetesCatalogWatcherEnabled | ||
| @AutoConfigureAfter({ Fabric8AutoConfiguration.class, KubernetesDiscoveryPropertiesAutoConfiguration.class }) | ||
| final class Fabric8CatalogWatchAutoConfiguration { | ||
| public final class Fabric8CatalogWatchAutoConfiguration { |
wind57
commented
Oct 21, 2025
| <version>${kubernetes-native-client.version}</version> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
k3s is not managed anymore by whomever brought it in (it does not event matter), so I added it explicitly
wind57
commented
Oct 21, 2025
| <version>1.4.13</version> | ||
| <configuration> | ||
| <repository>${docker.registry.organization}/${artifactId}</repository> | ||
| <repository>${docker.registry.organization}/${project.artifactId}</repository> |
There was a problem hiding this comment.
project.artifactId instead of (deprecated) artifactId
wind57
changed the title
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
wind57
commented
Oct 21, 2025
| * Rancher version to use for test-containers. | ||
| */ | ||
| private static final String RANCHER_VERSION = "rancher/k3s:v1.28.8-k3s1"; | ||
| private static final String RANCHER_VERSION = "rancher/k3s:v1.34.1-k3s1"; |
wind57
commented
Oct 21, 2025
| <dependency> | ||
| <groupId>org.testcontainers</groupId> | ||
| <artifactId>k3s</artifactId> | ||
| <artifactId>testcontainers-k3s</artifactId> |
There was a problem hiding this comment.
k3s testcontainers maven coordinates have changed, let's use the most recent ones
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.