Implement A CatalogWatch for Kubernetes Java Client

[wind57]

I am trying to understand what is the purpose of KubernetesCatalogWatch in the fabric8 implementation of discovery. It seems to me that KubernetesDiscoveryClient is an implementation of DiscoveryClient and KubernetesCatalogWatch was an initial implementation before that one existed.

As such, I am very inclined to delete it from the repo... unless I am missing something. what do you think? thank you

[wind57]

seems like spring-boot-admin relies on this for getting proper heartbeat events, so no, we can't delete it.

[wind57]

what I find interesting is that such an implementation does not exist in k8s-native. May be someone can explain...

[ryanjbaxter]

I dont know the exact history here, but this was modeled about ConsulCatalogWatch and it appears to publish a HeartBeat event when the services change. What that is used for I am not sure. @spencergibb can you describe how ConsulCatalogWatch is used?

It is not a DiscoveryClient implementation as far as I can tell.

[spencergibb]

it appears to publish a HeartBeat event when the services change.

That's exactly right. Then something can use that event to do something like spring cloud gateway can refresh routes and if there is a new one it can add it.

[ryanjbaxter]

May be someone can explain...

I think the reason why it doesn't exist in the k8s java client is simply we never implemented it