Remove workaround for data source cycle #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be fixed at Spring Boot side, see spring-projects/spring-boot@2f83a67 Signed-off-by: Yanming Zhou <[email protected]>
quaff
changed the title
ryanjbaxter
reviewed
Jan 21, 2025
|
|
||
| @Override | ||
| public void afterPropertiesSet() { | ||
| String cls = "org.springframework.boot.autoconfigure.jdbc.DataSourceInitializerInvoker"; |
There was a problem hiding this comment.
DataSourceInitializerInvoker was removed in the Spring Boot commit you referenced, correct?
Therefore the if statement below never actually gets executed, right?
There was a problem hiding this comment.
Not exactly, Spring Boot rework DataSource initialization to fix it entirely, it can be proved since @ConditionalOnClass(name = "javax.persistence.EntityManagerFactory") never matches since it renamed to jakarta.persistence.EntityManagerFactory.
ryanjbaxter
added
waiting for feedback
bug
and removed
waiting-for-triage
waiting for feedback
labels
ryanjbaxter
pushed a commit
that referenced
this pull request
Jan 22, 2025
It should be fixed at Spring Boot side, see spring-projects/spring-boot@2f83a67 Signed-off-by: Yanming Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be fixed at Spring Boot side, see spring-projects/spring-boot@2f83a67