Misnamed parameter "include_significant" on method Task.get_param_names

[MartinHeimsoth-V]

The classmethod Task.get_param_names has either a really confusingly misnamed parameter include_significant, or the implementation has a bug.
Example:

>>> class T(Task):
...     significant = Parameter(significant=True)
...     insignificant = Parameter(significant=False)
... 
>>> T.get_param_names()
['significant']
>>> T.get_param_names(include_significant=True)
['significant', 'insignificant']

So, I'd suggest to rename the parameter to include_insignificant (insignificant), or to change the implementation that on default it only returns the insignificant parameters, which would be weird though.

[nayopu]

@MartinHeimsoth-V
I was wondering the same thing.

Regarding your suggestions,

So, I'd suggest to rename the parameter to include_insignificant (insignificant), or to change the implementation that on default it only returns the insignificant parameters, which would be weird though.

The former suggestion sounds better. I see the include_significant is just a typo and expected behavior is to return only significant parameters on default.
The later suggestion of changing default behavior is a major change that can cause some problems in existing codes.

@daveFNbuck
I saw you were involved in the latest revision of this method. Do you have any idea on the expected behavior?

I made a related pull-request (#3168) before seeing this issue.
This request is accidently equivalent to the former suggestion of renaming include_significant.