This repository was archived by the owner on Jan 17, 2019. It is now read-only.
Calculate parent component’s view size up-front when creating children #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bug where child components would get a `CGSizeZero` container view size, if created before their parent component was resized by `UICollectionView`. This is done by using layout attributes directly when computing the container view size for root body components. This lookup is very fast (`O(1)`), since we cache the layout attributes by index path.
|
@spotify/objc-dev |
Current coverage is 92.82% (diff: 85.71%)@@ master #100 diff @@
==========================================
Files 57 57
Lines 4021 4027 +6
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3733 3738 +5
- Misses 288 289 +1
Partials 0 0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug where child components would get a
CGSizeZerocontainer view size, if created before their parent component was resized byUICollectionView. This is done by using layout attributes directly when computing the container view size for root body components.This lookup is very fast (
O(1)), since we cache the layout attributes by index path.