Skip to content

add scenario weights to fom cost #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

add scenario weights to fom cost #1187

merged 1 commit into from
Mar 17, 2025

Conversation

nnhjy
Copy link
Member

@nnhjy nnhjy commented Mar 14, 2025 •
edited
Loading

spotted by @kkozersk: every objective term is supposed to have a corresponding scenario weight

Checklist before merging

  • Documentation is up-to-date
  • Unit tests have been added/updated accordingly
  • Code has been formatted according to SpineOpt's style
  • Unit tests pass

@nnhjy
Copy link
Member Author

nnhjy commented Mar 14, 2025 •
edited
Loading

The first two runs of Julia 1.8 - windows-latest - x64 were failing without a reason or clue.

@nnhjy nnhjy requested a review from Tasqu March 14, 2025 17:29
Tasqu
Tasqu approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@Tasqu Tasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Tasqu Tasqu merged commit 9f31235 into master Mar 17, 2025
15 of 17 checks passed
@Tasqu Tasqu deleted the add-scenario-weight-to-fom-cost branch March 17, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tasqu Tasqu Tasqu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nnhjy @Tasqu