Use Policy field instead of PolicyIdentifiers in cert templates #6074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sorin Dumitru <[email protected]>
sorindumitru
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
sorindumitru
force-pushed
the
policy-identifiers-fixes
branch
from
625465a to
7fd2245
Compare
sorindumitru
changed the title
sorindumitru
force-pushed
the
policy-identifiers-fixes
branch
from
6839863 to
6f2910d
Compare
Signed-off-by: Sorin Dumitru <[email protected]>
Signed-off-by: Marcos Yacob <[email protected]> Signed-off-by: Sorin Dumitru <[email protected]>
sorindumitru
force-pushed
the
policy-identifiers-fixes
branch
from
6f2910d to
bd9ed8b
Compare
MarcosDY
reviewed
May 16, 2025
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
|
|
||
| - PolicyCredentials set by CredentialComposer plugins are now applied again to CA certificates (#6074) |
There was a problem hiding this comment.
how about something like:
- Regression where PolicyCredentials set by CredentialComposer plugins were not correctly applied to CA certificates. (#6074)
CHANGELOG.md
Outdated
| @@ -1,5 +1,11 @@ | |||
| # Changelog | |||
|
|
|||
| ## [1.12.1] - 2025-05-16 | |||
There was a problem hiding this comment.
Suggested change
| ## [1.12.1] - 2025-05-16 | |
| ## [1.12.2] - 2025-05-16 |
sorindumitru
force-pushed
the
policy-identifiers-fixes
branch
from
bd9ed8b to
587555a
Compare
amartinezfayo
previously approved these changes
May 16, 2025
Signed-off-by: Sorin Dumitru <[email protected]>
sorindumitru
force-pushed
the
policy-identifiers-fixes
branch
from
587555a to
c956a1d
Compare
amartinezfayo
approved these changes
May 19, 2025
MarcosDY
approved these changes
May 19, 2025
sorindumitru
added a commit
to sorindumitru/spire
that referenced
this pull request
May 20, 2025
…fe#6074) * Add a test for PolicyIdentifiers in server CA Signed-off-by: Sorin Dumitru <[email protected]> * Use Policy field for CA policies Signed-off-by: Sorin Dumitru <[email protected]> * Bump SPIRE v1.12.2 (spiffe#6052) Signed-off-by: Marcos Yacob <[email protected]> Signed-off-by: Sorin Dumitru <[email protected]> * Update CHANGELOG.md Signed-off-by: Sorin Dumitru <[email protected]> --------- Signed-off-by: Sorin Dumitru <[email protected]> Signed-off-by: Marcos Yacob <[email protected]> Co-authored-by: Marcos Yacob <[email protected]>
sorindumitru
added a commit
to sorindumitru/spire
that referenced
this pull request
May 20, 2025
…fe#6074) * Add a test for PolicyIdentifiers in server CA Signed-off-by: Sorin Dumitru <[email protected]> * Use Policy field for CA policies Signed-off-by: Sorin Dumitru <[email protected]> * Bump SPIRE v1.12.2 (spiffe#6052) Signed-off-by: Marcos Yacob <[email protected]> Signed-off-by: Sorin Dumitru <[email protected]> * Update CHANGELOG.md Signed-off-by: Sorin Dumitru <[email protected]> --------- Signed-off-by: Sorin Dumitru <[email protected]> Signed-off-by: Marcos Yacob <[email protected]> Co-authored-by: Marcos Yacob <[email protected]> Signed-off-by: Sorin Dumitru <[email protected]>
sorindumitru
added a commit
to sorindumitru/spire
that referenced
this pull request
May 20, 2025
…fe#6074) Co-authored-by: Marcos Yacob <[email protected]> Signed-off-by: Sorin Dumitru <[email protected]>
sorindumitru
added a commit
to sorindumitru/spire
that referenced
this pull request
May 20, 2025
…fe#6074) Co-authored-by: Marcos Yacob <[email protected]> Signed-off-by: Sorin Dumitru <[email protected]>
amartinezfayo
pushed a commit
that referenced
this pull request
May 20, 2025
* Use Policy field instead of PolicyIdentifiers in cert templates (#6074) Co-authored-by: Marcos Yacob <[email protected]> Signed-off-by: Sorin Dumitru <[email protected]> * Bump SPIRE v1.12.3 Signed-off-by: Sorin Dumitru <[email protected]> --------- Signed-off-by: Sorin Dumitru <[email protected]> Signed-off-by: Sorin Dumitru <[email protected]> Co-authored-by: Marcos Yacob <[email protected]>
tjons
pushed a commit
to tjons/spire
that referenced
this pull request
May 21, 2025
* Use Policy field instead of PolicyIdentifiers in cert templates (spiffe#6074) Co-authored-by: Marcos Yacob <[email protected]> Signed-off-by: Sorin Dumitru <[email protected]> * Bump SPIRE v1.12.3 Signed-off-by: Sorin Dumitru <[email protected]> --------- Signed-off-by: Sorin Dumitru <[email protected]> Signed-off-by: Sorin Dumitru <[email protected]> Co-authored-by: Marcos Yacob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
CredentialComposer plugins that use the PolicyIdentifiers field in the X509CAAttributes structure.
Description of change
Since go 1.24, to which we updated in the 1.12.0 release of SPIRE, the crypto/x509 package no longer applies the certificate policies from the PolicyIdentifier field when using the
CreateCertificatemethod. Instead of this the Policies field is used.The effect is that since the 1.12.0 release of SPIRE the CAs minted by deployments using a CredentialComposer plugin which specifies PolicyIdentifiers no longer have those fields populated in the CAs.
This can be mitigated on the affected releases (1.12.0 and 1.12.1) by setting the GODEBUG environment variable to ❯
x509usepolicies=0