Don't contact trust_bundle_url needlessly #6065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The agent contacts the trust_bundle_url on startup even if it already has a trust bundle. If connection fails, the agent fails. This requirement puts more load on the server needlessly, and either makes the agent lower availability or puts higher availability requirements on the server. Change it so that this doesn't happen. Signed-off-by: Kevin Fox <[email protected]>
kfox1111
requested review from
evan2645,
amartinezfayo,
sorindumitru,
MarcosDY and
rturner3
as code owners
|
Fix broken out of #5892 |
Signed-off-by: Kevin Fox <[email protected]>
pkg/agent/agent.go
Outdated
Comment on lines
118
to
119
| InsecureBootstrap := false | ||
| BootstrapTrustBundle, err := sto.LoadBundle() |
There was a problem hiding this comment.
The variables InsecureBootstrap and BootstrapTrustBundle are declared with an uppercase first letter, which is typically reserved for exported variables. Consider renaming them to insecureBootstrap and bootstrapTrustBundle.
pkg/agent/agent.go
Outdated
Comment on lines
152
to
153
| InsecureBootstrap := false | ||
| BootstrapTrustBundle, err := sto.LoadBundle() |
Signed-off-by: Kevin Fox <[email protected]>
amartinezfayo
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Documentation updated?Description of change
The agent contacts the trust_bundle_url on startup even if it already has a trust bundle. If connection fails, the agent fails. This requirement puts more load on the server needlessly, and either makes the agent lower availability or puts higher availability requirements on the server. Change it so that this doesn't happen.
Which issue this PR fixes
Fixes: #5893