Add ARM64 support for integration tests in GitHub workflows #6059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartinezfayo
requested review from
evan2645,
sorindumitru,
MarcosDY and
rturner3
as code owners
amartinezfayo
force-pushed
the
arm64-integration-tests
branch
from
a2a0b63 to
faac1a3
Compare
Signed-off-by: Agustín Martínez Fayó <[email protected]>
amartinezfayo
force-pushed
the
arm64-integration-tests
branch
from
faac1a3 to
faca7aa
Compare
.github/workflows/pr_build.yaml
Outdated
| integration: | ||
| name: integration (linux) | ||
| runs-on: ubuntu-22.04 | ||
| name: integration (${{ matrix.arch }}) |
There was a problem hiding this comment.
One small nit I have for this is that the name of the integration steps have lost the job index:
- PR Build / integration (linux) (5, 4)
+ PR Build / integration (x64)
I wonder if that's something that we can bring back, maybe something like:
Suggested change
| name: integration (${{ matrix.arch }}) | |
| name: integration (${{ matrix.arch }}) (${{ strategy.job-index}}/${{ strategy.job-total }}) |
Signed-off-by: Agustín Martínez Fayó <[email protected]>
sorindumitru
approved these changes
May 19, 2025
tjons
pushed a commit
to tjons/spire
that referenced
this pull request
May 21, 2025
) * Add ARM64 support for integration tests on GitHub workflows Signed-off-by: Agustín Martínez Fayó <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3740.