Skip to content

Allow reads for cache events to go to RO DB #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

faisal-memon
Copy link
Contributor

@faisal-memon faisal-memon commented Feb 28, 2025

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality

events based cache

Description of change

Sets tolerate stale for reading events

Which issue this PR fixes

partially addresses #5624

Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @faisal-memon!

@sorindumitru sorindumitru force-pushed the events-cache-allow-stale branch from c30c380 to 852a2c1 Compare March 11, 2025 18:46
@sorindumitru sorindumitru merged commit 384a1a9 into spiffe:main Mar 11, 2025
35 checks passed
@sorindumitru sorindumitru added this to the 1.12.0 milestone Mar 11, 2025
@faisal-memon faisal-memon deleted the events-cache-allow-stale branch March 11, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants