Accomodate more plugin config shapes #3999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
Recent changes to the plugin config parsing code required to enable deterministic plugin ordering were too restrictive on the shapes of plugin configuration, causing some previously-allowed configurations to become invalid. This PR changes parsing code to be more flexible when determining order. It walks the AST and builds up a stack of ast nodes until it has enough object key's in the stack to determine the plugin type and name. The actual config parsing is then done separately using the more or less the same config shape as before, changing to a list of maps of maps to accomodate the way HCL parses into the AST. Signed-off-by: Andrew Harding <[email protected]>
azdagron
force-pushed
the
fix-plugin-config-parsing
branch
from
1518bdd to
fadfc20
Compare
Basavaraju-G
pushed a commit
to Basavaraju-G/spire
that referenced
this pull request
May 3, 2023
Recent changes to the plugin config parsing code required to enable deterministic plugin ordering were too restrictive on the shapes of plugin configuration, causing some previously-allowed configurations to become invalid. This PR changes parsing code to be more flexible when determining order. It walks the AST and builds up a stack of ast nodes until it has enough object key's in the stack to determine the plugin type and name. The actual config parsing is then done separately using the more or less the same config shape as before, changing to a list of maps of maps to accomodate the way HCL parses into the AST. Signed-off-by: Andrew Harding <[email protected]> Signed-off-by: Basavaraju-G <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to the plugin config parsing code required to enable deterministic plugin ordering were too restrictive on the shapes of plugin configuration, causing some previously-allowed configurations to become invalid.
This PR changes parsing code to be more flexible when determining order. It walks the AST and builds up a stack of ast nodes until it has enough object key's in the stack to determine the plugin type and name.
The actual config parsing is then done separately using the more or less the same config shape as before, changing to a list of maps of maps to accomodate the way HCL parses into the AST.