issue #3497 : Removed deprecated enabled flag from InMem telemetry config

[vish-k]

…nfig

Pull Request check list

• [ x] Commit conforms to CONTRIBUTING.md?
• [ x] Proper tests/regressions included?
• [ x] Documentation updated?

Affected functionality

Description of change

Which issue this PR fixes
fixes #3497 Remove deprecated "enabled" flag from InMem telemetry config

[azdagron]

Thanks, @vish-k !

[azdagron]

Looks like we need DCO signoff on your commit.l You can follow the details of the failed DCO workflow for a description of how to solve.

[vish-k]

Thanks for your patience. I followed the steps to add DCO commit. Pls let me know if this works.

[azdagron]

Looks like it is still missing. I'd rebase the commit on origin/main and then do a git commit -s --amend to add the signoff, and then force push to the PR branch.

[azdagron]

DCO signoff is still unhappy.

[vish-k]

It's still complaining about earlier commit [17d7827] which I deleted. The latest commit has "Signed-off-by". Is there any way to bypass check for deleted commit? I'm sorry, this is my first commit so I'm messing this up. Should I just redo the fork and create new PR?

[azdagron]

That commit is still part of the PR branch. I suggest rebasing your PR branch on top of main instead of merging main.

[vish-k]

Since I was working a fork in my repo, I didn't create separate branch. I just made changes to local main branch, pushed to main in my repo/main and PR is merge my main into spire/main.

[azdagron]

Sure, that's fine. So the main branch on your fork is the PR branch. I'd suggest rebasing main on your fork on top of main from this repo.

[azdagron]

Unfortunately DCO is not something we can skip. If you hit me up on the SPIFFE slack, I'd be happy to help you get this sorted.

[azdagron]

Looks like the linter is failing:

pkg/common/telemetry/inmem_test.go:13: unnecessary leading newline (whitespace)

[vish-k]

Ok. I will check it.

…

On Fri, Jan 27, 2023, 5:28 PM Andrew Harding ***@***.***> wrote: Looks like the linter is failing: pkg/common/telemetry/inmem_test.go:13: unnecessary leading newline (whitespace) — Reply to this email directly, view it on GitHub <#3796 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADFX6WKOEEDEJWWZCIIVCO3WURDXVANCNFSM6AAAAAAUFZF4M4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[vish-k]

It's failing with "unnecessary leading newline (whitespace)" but there is no whitespace or newline.

I tried vs code, gofmt and even nolint directive for golangci-lint but no luck so far. Do you have any suggestion?

[azdagron]

Remove this empty line at the beginning of the TestInMem function to satisfy the linter.

[vish-k]

Thanks! fixed it.