Don't run nightly builds from forks #3768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
sorindumitru
changed the title
sorindumitru
changed the title
Otherwise this ends up being run on personal forks of projects. It's not a big issue, but fork owners will get nightly messages about build failures. Signed-off-by: Sorin Dumitru <[email protected]>
|
Thanks @sorindumitru. This won't be needed once #3785 is merged, since it removes publishing to GCR. Nightly will work fine on your fork after that. I'll go ahead and close this in favor of 3785. |
That sounds ok to me, but that PR still has the login and publish steps in the nightly build, will those be removed? |
|
The nightly still publishes to GHCR. Only the publishing of GCR will be removed. Your fork should have no problems publishing the images to GHCR for your org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Nightly builds
Description of change
Only run the nightly build job when repository owner (or org) is 'spire'.
Which issue this PR fixes
The nightly build job was triggered from personal forks of this repo. It didn't have access to the necessary secrets so it was failed leading to daily build failure email spam for fork owners.