Disable in-mem telemetry collection by default #3492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR spiffe#1248 provided a mechanism to disable the in-memory telemetry collector, which until that point had been always on. The new configuration block and `enabled` configurable were introduced in a backwards compatible way, with a warning that the in-memory telemetry collector would default to disabled in a future release. This commit changes the behavior to disable the in-memory telemetry collector by default. In addition, it adds a warning log level that the "enabled" flag is now deprecated and will be removed in a future release. We can remove this flag in SPIRE 1.6.0. Signed-off-by: Andrew Harding <[email protected]>
azdagron
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
There was a problem hiding this comment.
Thank you @azdagron, looks great!
I think the only missing piece is to update server_full.conf, looks great otherwise.
Signed-off-by: Andrew Harding <[email protected]>
|
Whoops! Thanks for catching that, @amartinezfayo! Updated. |
MarcosDY
reviewed
Oct 11, 2022
doc/telemetry_config.md
Outdated
| @@ -53,7 +53,7 @@ You may use all, some, or none of the collectors. The following collectors suppo | |||
| #### `In-Mem` | |||
| | Configuration | Type | Description | Default | | |||
| |---------------|--------|-----------------------|---------| | |||
There was a problem hiding this comment.
may we keep following the table format that was introduced recently?
There was a problem hiding this comment.
Oh yep. Thanks for pointing that out. Fixed.
Signed-off-by: Andrew Harding <[email protected]>
This was referenced Oct 12, 2022
stevend-uber
pushed a commit
to stevend-uber/spire
that referenced
this pull request
Oct 16, 2023
PR spiffe#1248 provided a mechanism to disable the in-memory telemetry collector, which until that point had been always on. The new configuration block and `enabled` configurable were introduced in a backwards compatible way, with a warning that the in-memory telemetry collector would default to disabled in a future release. This commit changes the behavior to disable the in-memory telemetry collector by default. In addition, it adds a warning log level that the "enabled" flag is now deprecated and will be removed in a future release. We can remove this flag in SPIRE 1.6.0. Signed-off-by: Andrew Harding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1248 provided a mechanism to disable the in-memory telemetry collector, which until that point had been always on. The new configuration block and
enabledconfigurable were introduced in a backwards compatible way, with a warning that the in-memory telemetry collector would default to disabled in a future release.This commit changes the behavior to disable the in-memory telemetry collector by default. In addition, it adds a warning log level that the "enabled" flag is now deprecated and will be removed in a future release. We can remove this flag in SPIRE 1.6.0.