Bump Go to 1.19.5-alpine for docker build #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we move to the latest (go1.19.5 was released recently)? |
Definitely, I'm running behind, should have double checked. |
Signed-off-by: Marco Franssen <[email protected]>
marcofranssen
force-pushed
the
bump-go-119-alpine
branch
from
9495241 to
f20c8e1
Compare
marcofranssen
changed the title
|
@marcofranssen Can you add the fixes #42 tag to link the issue? |
Done. |
azdagron
approved these changes
Jan 13, 2023
|
The makefile currently requires Bash. Should this be changed also? |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to alpine as we will have same like we will do for spiffe-csi and spire images. Also see #51
Supercedes and closes #46
fixes #42