spire-controller-manager 0.4.0 support #60

kfox1111 · 2023-10-25T19:48:16Z

Updates image and CRD's to 0.4.0. Adds autoPopulateDNSNames and className support which were added in 0.4.0.

Signed-off-by: Kevin Fox <[email protected]>

kfox1111 · 2023-10-25T20:03:52Z

Depends on this already merged feature getting a release: spiffe/spire-controller-manager#230

charts/spire/charts/spire-server/values.yaml

Signed-off-by: Kevin Fox <[email protected]>

Signed-off-by: kfox1111 <[email protected]>

Signed-off-by: Kevin Fox <[email protected]>

Signed-off-by: kfox1111 <[email protected]>

Signed-off-by: Kevin Fox <[email protected]>

marcofranssen

Couple of suggestions on renaming some stuff and adding more context for understanding the feature. I think people new to the feature (like me) will be unable to follow allong.

charts/spire/README.md

charts/spire/charts/spire-server/README.md

charts/spire/charts/spire-server/templates/_helpers.tpl

charts/spire/charts/spire-server/templates/controller-manager-cluster-ids.yaml

charts/spire/charts/spire-server/values.yaml

…cluster-ids.yaml Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: kfox1111 <[email protected]>

Signed-off-by: Kevin Fox <[email protected]>

Signed-off-by: kfox1111 <[email protected]>

Signed-off-by: Kevin Fox <[email protected]>

kfox1111 · 2023-11-02T22:25:47Z

@marcofranssen What would be the best path forward here? Would it help to have a call?

charts/spire/README.md

examples/nested/run-tests.sh

charts/spire/charts/spire-server/templates/controller-manager-webhook.yaml

faisal-memon · 2023-11-04T04:16:39Z

@kfox1111 Overall looks good. Thanks for adding the other missing controller manager features. Just some minor questions inline.

Co-authored-by: Faisal Memon <[email protected]> Signed-off-by: kfox1111 <[email protected]>

Signed-off-by: kfox1111 <[email protected]>

Signed-off-by: Kevin Fox <[email protected]>

marcofranssen

LGTM 🚀 Lets get some community feedback on this feature and its UX from a Helm perspective.

* 6c0a4fb Auto tornjak url (#89) * f2758a8 Autogen jwtIssuer (#88) * 93c20c6 Merge pull request #83 from spiffe/doc-ingress-patch * c662b0c Merge branch 'main' into doc-ingress-patch * de8cbc8 Bump github.com/onsi/gomega from 1.29.0 to 1.30.0 in /tests (#90) * 1de838e Bump helm.sh/helm/v3 from 3.13.1 to 3.13.2 in /tests (#91) * daf9d55 Merge branch 'main' into doc-ingress-patch * aaeca00 Fix tests after renaming files * 0320c3f Cleanup documentation * 37cd9f2 Update to SPIRE 1.8.4 (#84) * bd7879a Fix the typo in the production ingress README * 805d869 spire-controller-manager 0.4.0 support (#60) * edf2381 Bump sigstore/cosign-installer from 3.1.2 to 3.2.0 (#85) * 0ed6d92 Bump test chart dependencies * f7b6140 Fix docs * a7e8785 Add another missing one * 3778597 Add missing ClusterSPIFFEID fields * 9b31f3d Bump helm/chart-testing-action from 2.6.0 to 2.6.1 * d6583be Add missing no cleanup flags to example tests (#79) * 81cc2dc Ingress type openshift (#52) * 2dce90f Bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (#75) * f08ebd3 Patch Tornjak ingress (#74) * 6a6aa1c Cosign download fix (#72) * 3b01684 Support Openshift deployment (#13) * ed23d8b Simple ingress support (#48) * b354413 Fix incorrect nesting of priorityClassName (#67) * 09ebfc9 Bump test chart dependencies (#68) * d50d78d Fix ingress annotation variable for tornjak server (#66) * b813807 Update docs to simplify, clarify, and prioritize ease of install/upgrade (#62) * 5ad35bd Merge pull request #59 from sabre1041/spire-agent-nodename * 02d445c Update charts/spire/README.md * 9bd7f43 Added environment variable to spire-agent to inject node name * fb64f8d Bump github.com/onsi/gomega from 1.28.1 to 1.29.0 in /tests (#61) * 30d0f59 Update helm-charts repository URL (#58) * 7924323 Specify ingress controller type (#43) * 0b17434 Bump test chart dependencies (#54) * a419903 Bump github.com/onsi/gomega from 1.28.0 to 1.28.1 in /tests (#53) * 5025025 Fix doc missing end tag (#46) * cf226a7 Bump actions/checkout from 4.1.0 to 4.1.1 (#42) Signed-off-by: Faisal Memon <[email protected]>

drewwells · 2024-05-02T16:48:57Z

charts/spire/charts/spire-server/templates/pre-upgrade-hook.yaml

+{{- $webhookname := printf "%s-%s-webhook" .Release.Namespace (include "spire-controller-manager.fullname" .) }}
+{{- $oldwebhookname := printf "%s-webhook" (include "spire-controller-manager.fullname" .) }}
+{{- if not (lookup "admissionregistration.k8s.io/v1" "ValidatingWebhookConfiguration" "" $webhookname) }}
+{{- $webhookname = $oldwebhookname }}
+{{- end }}


These short term object renames need to be major releases. It's impossible to upgrade from 0.14.0 to 0.20.0 due to this rename logic being removed somewhere b/t here and 0.20.0. Under semver, minor releases should just work, but that's not the case.

Add support for the new spire-controller-manager class feature

9fe0bd9

Signed-off-by: Kevin Fox <[email protected]>

kfox1111 requested review from marcofranssen, dfeldman, faisal-memon and mrsabath as code owners October 25, 2023 19:48

kfox1111 marked this pull request as draft October 25, 2023 19:48

Fix docs. Swich nested deployment to use controller manager

ef589a9

Signed-off-by: Kevin Fox <[email protected]>

kfox1111 force-pushed the controller-manager-class branch from 5151f29 to ef589a9 Compare October 25, 2023 20:03

faisal-memon reviewed Oct 25, 2023

View reviewed changes

charts/spire/charts/spire-server/values.yaml Outdated Show resolved Hide resolved

kfox1111 added 17 commits October 25, 2023 13:12

Incorperate feedback

91c49f5

Signed-off-by: Kevin Fox <[email protected]>

Merge branch 'main' into controller-manager-class

eff2e04

Signed-off-by: kfox1111 <[email protected]>

Test with nightly

7f195fb

Signed-off-by: Kevin Fox <[email protected]>

Fix global object naming clash

cdf6e14

Signed-off-by: Kevin Fox <[email protected]>

Fix missing dot

690ff7e

Signed-off-by: Kevin Fox <[email protected]>

Fix naming conflict with cluster ids

fb01de4

Signed-off-by: Kevin Fox <[email protected]>

Fix scoping issue

d683f5f

Signed-off-by: Kevin Fox <[email protected]>

Fix typo

1e30d9e

Signed-off-by: Kevin Fox <[email protected]>

Fix webhook name collision

0ddc76b

Signed-off-by: Kevin Fox <[email protected]>

Fix webhook reference and add note to user about className

85a12a9

Signed-off-by: Kevin Fox <[email protected]>

Upgrade has to work on the old version of the object before rename

93ff943

Signed-off-by: Kevin Fox <[email protected]>

Fix formatting

b8d276b

Signed-off-by: Kevin Fox <[email protected]>

Remove extra junk from job

f7466a4

Signed-off-by: Kevin Fox <[email protected]>

Easier local runs and wait for crds

3db9a0c

Signed-off-by: Kevin Fox <[email protected]>

Add missing crd upgrade

6ce33bc

Signed-off-by: Kevin Fox <[email protected]>

Merge branch 'main' into controller-manager-class

04a02cb

Signed-off-by: kfox1111 <[email protected]>

Update upgrade notes

17283dd

Signed-off-by: Kevin Fox <[email protected]>

marcofranssen requested changes Oct 27, 2023

View reviewed changes

kfox1111 and others added 2 commits October 27, 2023 09:05

Update charts/spire/charts/spire-server/templates/controller-manager-…

51599c3

…cluster-ids.yaml Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: kfox1111 <[email protected]>

Incorperate feedback

7aac57c

Signed-off-by: Kevin Fox <[email protected]>

kfox1111 added 2 commits November 2, 2023 13:42

Bump version to the released 0.4.0

d4f6d45

Signed-off-by: kfox1111 <[email protected]>

Merge branch 'main' into controller-manager-class

d344095

kfox1111 marked this pull request as ready for review November 2, 2023 20:42

kfox1111 added 3 commits November 2, 2023 14:07

Fix docs

80036b6

Signed-off-by: Kevin Fox <[email protected]>

Merge in crd changes from upstream

1fff86d

Signed-off-by: Kevin Fox <[email protected]>

Add auto populate dns

8bbd20a

Signed-off-by: Kevin Fox <[email protected]>

kfox1111 changed the title ~~Add support for the new spire-controller-manager class feature~~ spire-controller-manager 0.4.0 support Nov 2, 2023

kfox1111 added 2 commits November 3, 2023 08:26

Merge branch 'main' into controller-manager-class

48b7644

Merge branch 'main' into controller-manager-class

3e9c053

faisal-memon reviewed Nov 4, 2023

View reviewed changes

charts/spire/README.md Outdated Show resolved Hide resolved

faisal-memon reviewed Nov 4, 2023

View reviewed changes

examples/nested/run-tests.sh Show resolved Hide resolved

faisal-memon reviewed Nov 4, 2023

View reviewed changes

charts/spire/charts/spire-server/templates/controller-manager-webhook.yaml Show resolved Hide resolved

Update charts/spire/README.md

a009101

Co-authored-by: Faisal Memon <[email protected]> Signed-off-by: kfox1111 <[email protected]>

faisal-memon modified the milestones: 0.16.0, 0.15.0 Nov 6, 2023

kfox1111 added 2 commits November 6, 2023 03:37

Merge branch 'main' into controller-manager-class

3ccca0d

Signed-off-by: kfox1111 <[email protected]>

Fix docs

0f59c4e

Signed-off-by: Kevin Fox <[email protected]>

marcofranssen enabled auto-merge (squash) November 6, 2023 12:27

Merge branch 'main' into controller-manager-class

8c9d5fc

marcofranssen approved these changes Nov 8, 2023

View reviewed changes

Merge branch 'main' into controller-manager-class

ac8f0d8

marcofranssen merged commit 805d869 into main Nov 8, 2023

marcofranssen deleted the controller-manager-class branch November 8, 2023 10:43

faisal-memon mentioned this pull request Nov 9, 2023

Bump spire Helm Chart version from 0.14.0 to 0.15.0 #92

Merged

faisal-memon mentioned this pull request Nov 12, 2023

Upgrade Job always changes #99

Closed

drewwells reviewed May 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

spire-controller-manager 0.4.0 support #60

spire-controller-manager 0.4.0 support #60

Uh oh!

kfox1111 commented Oct 25, 2023 •

edited

Loading

Uh oh!

kfox1111 commented Oct 25, 2023

Uh oh!

Uh oh!

marcofranssen left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kfox1111 commented Nov 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

faisal-memon commented Nov 4, 2023

Uh oh!

marcofranssen left a comment

Uh oh!

drewwells May 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

spire-controller-manager 0.4.0 support #60

spire-controller-manager 0.4.0 support #60

Uh oh!

Conversation

kfox1111 commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kfox1111 commented Oct 25, 2023

Uh oh!

Uh oh!

marcofranssen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kfox1111 commented Nov 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

faisal-memon commented Nov 4, 2023

Uh oh!

marcofranssen left a comment

Choose a reason for hiding this comment

Uh oh!

drewwells May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kfox1111 commented Oct 25, 2023 •

edited

Loading

drewwells May 2, 2024 •

edited

Loading