Skip to content

Fix shader uniform memory leaks #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2020
Merged

Fix shader uniform memory leaks #317

merged 3 commits into from
Nov 18, 2020

Conversation

@postcasio
Copy link
Contributor

Free memory for int and float array uniforms when the uniform or shader is destroyed.

@postcasio
Fix shader uniform memory leaks
bd1a3f8 
Free memory for int and float array uniforms when the uniform or shader is destroyed.
fatcerberus
fatcerberus requested changes Nov 17, 2020
View reviewed changes
Copy link
Member

@fatcerberus fatcerberus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor style complaints; the change looks right to me otherwise.

fatcerberus
fatcerberus approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@fatcerberus fatcerberus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for now. I'll see if I can find a way to get rid of the code duplication some other time Thanks for finding the memory leak, kind of a silly oversight on my part.

@fatcerberus fatcerberus merged commit aaea613 into spheredev:master Nov 18, 2020
fatcerberus pushed a commit that referenced this pull request Nov 22, 2020
@postcasio @fatcerberus
Fix shader uniform memory leaks (#317)
e4c343a 
Free memory for int and float array uniforms when the uniform or shader
is destroyed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fatcerberus fatcerberus fatcerberus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@postcasio @fatcerberus