Skip to content

[TrivialPatches] Typos in README.md, fix and update CI, update projects list... #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 20, 2019
Merged

[TrivialPatches] Typos in README.md, fix and update CI, update projects list... #840

merged 17 commits into from
Mar 20, 2019

Conversation

@umarcor
Copy link
Contributor

@umarcor umarcor commented Mar 18, 2019 •
edited
Loading

This PR collects several other PRs which are considered to be trivial, as an effort to help the maintainers in getting some work out of their tasklist.

Close #769 (@ariefrahmansyah)
Close #777 (@jayunit100)
Close #779 (@indradhanush)
Close #806 (@saromanov)
Close #826 (@linzhaoming)
Close #831 and Close #832 and Close #833 (@peter-edge)
Close #839
Close #786 (@praveensastry)
Close #824 (@joshuabezaleel)

Furthermore, the projects that use Cobra are shown separated by commas, instead of a long vertical list.

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

This was referenced Mar 18, 2019
Closed
Draft
@umarcor
Copy link
Contributor Author

umarcor commented Mar 19, 2019

The latest commit adds colored tests to Travis:

eparis
eparis reviewed Mar 19, 2019
View reviewed changes
jayunit100 and others added 16 commits March 19, 2019 21:24
@jayunit100 @umarcor
specify the color as the required arg (spf13#777)
0a6c06e
@indradhanush @umarcor
command: fix typo in docstring of InheritedFlags (spf13#779)
7bab206
@saromanov @umarcor
remove redundant 'else' (spf13#806)
5e9ccc4
@linzhaoming @umarcor
update README.md (spf13#826)
d1e8e8b 
Fix the comment: consistent with others
@bufdev @umarcor
fix(ci): use go vet, update to Go 1.12, update shellcheck to v0.4.6 (s…
bbec970 
…pf13#832)
@bufdev @umarcor
add go.mod and go.sum (spf13#833)
ee67eb4
@umarcor
chore(travis): move 'diff' job to separate stage in Travis (spf13#839)
1820a06
@umarcor
chore(travis): use language configuration list instead of explicit en…
9a856c2 
…tries in matrix.include (spf13#839)
@umarcor
chore(travis): update shellcheck-docker to v0.6.0 (spf13#839)
6da1f4a
@praveensastry @umarcor
add istio to the list of projects built with Cobra (spf13#786)
1bc7f67
@bufdev @umarcor
add uber/prototool as a project built with Cobra (spf13#831)
ccef21e
@joshuabezaleel @umarcor
add mattermost-server as a project built with Cobra (spf13#824)
09c3b19
@umarcor
update(README.md): separate projects by commas, instead of using a list
685e640
@umarcor
chore: update viper to v1.3.2 and go-md2man to v1.0.10
7a54049
@umarcor
fix: convert CRLF to LF when comparing files
c0ff9f1
@umarcor
use kyoh86/richgo to provide colored test outputs
37c2ef0
@eparis eparis merged commit 5755ecf into spf13:master Mar 20, 2019
@umarcor umarcor deleted the trivial branch March 20, 2019 21:29
@umarcor umarcor mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eparis eparis eparis left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.