Changes NoArgs to report invalid argument #666
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course, I'm now having second thoughts. I think the behavior of NoArgs should be a little more nuanced. If you have no subcommands, it should definitely return "invalid argument". If you have subcommands and you have exactly one extra argument, it should probably say "unknown command", otherwise it would say "invalid arguments". Also, it should show all the extra arguments, not just the first one. |
neurocline
force-pushed
the
change-noargs-return
branch
from
a4c71bc to
9b6c785
Compare
NoArgs currently reports "unknown command" in all cases, which can be is a little misleading to the user if there are no subcommands. Change it as follows - if subcommands and one extra arg, say "unknown command" - otherwise, say "invalid argument(s)" and show all extra args This should produce more meaningful error messages to users, and works for both the root and sub-commands.
neurocline
force-pushed
the
change-noargs-return
branch
from
9b6c785 to
d8e244d
Compare
|
I updated my pull request with the behavior outlined in the previous message. |
|
👍 |
4 tasks
|
This PR is being marked as stale due to a long period of inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates NoArgs to also report invalid argument
NoArgs currently reports "unknown command" in all cases, which
can be is a little misleading to the user if there are no
subcommands. Change it as follows
This should produce more meaningful error messages to users, and
works for both the root and sub-commands.