-
Notifications
You must be signed in to change notification settings - Fork 3k
Closed
Labels
adminFor general admin tasks to be done usualy by maintainersFor general admin tasks to be done usualy by maintainerslifecycle/frozenPrevents GitHub actions from labeling issues / PRs with stale and rottenPrevents GitHub actions from labeling issues / PRs with stale and rotten
Description
Problem
Today, we have wildy inconsistent license headers in our go
source files.
- I notice that many of the
go
files do not have a license header. - Others have one that declares a copy-write under @spf13 and the Apache 2.0 license
- Some contributors may be confused and attempt to add different headers (example: Added asciidoc generation and associated tests. #1698)
Expectation
From my understanding of the Apache 2.0 license, source files should have the license header, otherwise, it seems that only some of the source code is under the Apache 2.0 license and the others are ... unlicensed?
We should be consistent.
Further, we should set up a CICD job to fail if someone commits something without the license header.
@spf13 - can you advice here? Should the expectation be that we have:
// Copyright © 2022 Steve Francia <[email protected]>.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
in all go source files?
marckhouzam and willbeason
Metadata
Metadata
Assignees
Labels
adminFor general admin tasks to be done usualy by maintainersFor general admin tasks to be done usualy by maintainerslifecycle/frozenPrevents GitHub actions from labeling issues / PRs with stale and rottenPrevents GitHub actions from labeling issues / PRs with stale and rotten