Skip to content

Review inconsistent go file license headers #1699

@jpmcb

Description

@jpmcb

Problem

Today, we have wildy inconsistent license headers in our go source files.

Expectation

From my understanding of the Apache 2.0 license, source files should have the license header, otherwise, it seems that only some of the source code is under the Apache 2.0 license and the others are ... unlicensed?

We should be consistent.

Further, we should set up a CICD job to fail if someone commits something without the license header.


@spf13 - can you advice here? Should the expectation be that we have:

// Copyright © 2022 Steve Francia <[email protected]>.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

in all go source files?

Metadata

Metadata

Assignees

No one assigned

    Labels

    adminFor general admin tasks to be done usualy by maintainerslifecycle/frozenPrevents GitHub actions from labeling issues / PRs with stale and rotten

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions