Command context is not properly passed on to sub-commands

[lewisparma]

When using 'ExecuteContext' on the parent command, the context is not properly passed on to sub commands. It's passed on only the first time, then on the following invocations the first passed value is used. The culprit seems to be this section from commands.go:

// We have to pass global context to children command
// if context is present on the parent command.
if cmd.ctx == nil {
cmd.ctx = c.ctx
}

the parent context should always be passed on to the child command, not just when the child context is null.

[github-actions]

This issue is being marked as stale due to a long period of inactivity

[github-actions]

This issue is being marked as stale due to a long period of inactivity

[utku-caglayan]

Here is a workaround for anyone struggling with this:

type CobraMutableCtx struct {
	Internal context.Context
}
func (c *CobraMutableCtx) Deadline() (deadline time.Time, ok bool) {
	return c.Internal.Deadline()
}
func (c *CobraMutableCtx) Done() <-chan struct{} {
	return c.Internal.Done()
}
func (c *CobraMutableCtx) Err() error {
	return c.Internal.Err()
}
func (c *CobraMutableCtx) Value(key interface{}) interface{} {
	return c.Internal.Value(key)
}
...
var cobraCtx CobraMutableCtx
cobraCtx.Internal = context.TODO() // your context
cobraCmd.ExecuteContext(&cobraCtx) // this will be passed to subcommands
cobraCtx.Internal, cmdCancel = context.WithCancel(ctx) // your context
cmdCancel()
cobraCmd.ExecuteContext(&cobraCtx) // this time subcommands will use cancelled context

[johnSchnake]

Is there any counterargument for the context not being passed to the child when non-nil?

Unfortunately it seems like it would be a breaking change for anyone who already worked around it or began to depend on this code flow.

Out of curiosity, whats the situation with the multiple invocations? Is it tests that are causing the problem? I wonder if that was part of the reason why the context wasn't to be overwritten: so that you could specify it manually to avoid the inheritance.

[marckhouzam]

Very similar to #1469