-
Notifications
You must be signed in to change notification settings - Fork 1
Update .gitignore
to ignore data directory for main worker
#69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added entry to ignore the `data` directory within the `workers/main` path, which contains runtime and generated data. This change helps maintain a cleaner repository by preventing unnecessary files from being tracked. These modifications enhance the project's file management and ensure that generated data does not clutter the version control system.
📝 WalkthroughWalkthroughA new rule was added to the Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.gitignore (1)
151-152
: Path-style inconsistent with rest of fileMost existing directory rules omit a leading “/” (e.g.
node_modules/
,coverage
,volumes
). Sticking to one style keeps the ignore file easier to scan and avoids surprises if the repo is later cloned inside another path and the rule is re-used.-# Ignore data directory for main worker (contains runtime/generated data) /workers/main/data/ +# Ignore data directory for main worker (contains runtime/generated data) +workers/main/data/Semantics remain identical because the pattern is already anchored by the initial path segment, so this is purely a consistency polish.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.gitignore
(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/temporal-project-structure.mdc:0-0
Timestamp: 2025-06-24T12:29:48.641Z
Learning: Shared code, such as utilities, types, and configuration that are reused across multiple Temporal workers, should be placed in a dedicated 'workers-shared/' directory at the project root to maximize reuse and avoid duplication.
Learnt from: anatolyshipitz
PR: speedandfunction/automatization#34
File: workers/main/src/workflows/financial/FinancialReportFormatter.ts:3-7
Timestamp: 2025-05-30T17:57:21.010Z
Learning: User anatolyshipitz prefers to keep code implementations simple during early development stages rather than adding comprehensive error handling and validation. They consider extensive type annotations and error handling "redundant" when focusing on core functionality and testing.
.gitignore (4)
Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/temporal-project-structure.mdc:0-0
Timestamp: 2025-06-24T12:29:48.641Z
Learning: Shared code, such as utilities, types, and configuration that are reused across multiple Temporal workers, should be placed in a dedicated 'workers-shared/' directory at the project root to maximize reuse and avoid duplication.
Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/temporal-project-structure.mdc:0-0
Timestamp: 2025-06-24T12:29:48.641Z
Learning: In Temporal-based TypeScript projects, each worker should be structured as an independent package under 'workers/<worker-name>/', with clear separation of workflows, activities, entry point, and documentation to promote modularity and maintainability.
Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-07-01T10:18:31.706Z
Learning: Applies to volumes/{n8n_data,opensearch-data,postgresql-data}/** : Persistent data for all services must be stored in the volumes/ directory, with service-specific subdirectories (n8n_data/, opensearch-data/, postgresql-data/)
Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/docker-configuration.mdc:0-0
Timestamp: 2025-07-01T10:18:09.628Z
Learning: Applies to volumes/**/* : All service data must be persisted in Docker volumes mapped to the local volumes/ directory, such as ./volumes/n8n_data, ./volumes/opensearch-data, and ./volumes/postgresql-data
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Docker Security Scanning (temporal, Dockerfile.temporal, temporal-test:latest)
- GitHub Check: Docker Security Scanning (n8n, Dockerfile.n8n, n8n-test:latest)
- GitHub Check: SonarQube
- GitHub Check: Service Availability Check
- GitHub Check: Analyze (actions)
- GitHub Check: Analyze (javascript-typescript)
🔍 Vulnerabilities of
|
digest | sha256:da30eca7154c7c4cb2616e31f7411021ea9146d5b15c68adf2a57df4c52b164c |
vulnerabilities | |
platform | linux/amd64 |
size | 218 MB |
packages | 358 |
📦 Base Image alpine:3
also known as |
|
digest | sha256:1c4eef651f65e2f7daee7ee785882ac164b02b78fb74503052a26dc061c90474 |
vulnerabilities |
Description
| ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
Description | ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
Description
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
data
directory within theworkers/main
path, which contains runtime and generated data. This change helps maintain a cleaner repository by preventing unnecessary files from being tracked.These modifications enhance the project's file management and ensure that generated data does not clutter the version control system.