fix bug setting Header #1890
Merged
fix bug setting Header #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, i'm at work so don't have the time to follow all the process. But this shows where the fix needs to be made. Hopefully someone can finish it off by added tests and all the other stuff. Thanks |
patriksvensson
approved these changes
Sep 5, 2025
|
No tests needed for this. Thanks! |
|
Merged! Thank you for your contribution. Much appreciated! 👍 |
This was referenced Sep 8, 2025
Merged
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1889
Changes
Please upvote 👍 this pull request if you are interested in it.